-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for use in traditional CI builds. #30
Conversation
I know this is a work in progress but merging this would entirely break The |
You're right, I was just trying to get it to build quickly while I was testing.
|
This is now able to be merged independently of #29. Plus, it should be entierly non-breaking. |
It seems that the action now no longer adds a comment regarding the compression info... |
Just realized why: it's because the image isn't being optimized enough. |
@benschwarz can you have a look? |
I will. Bit snowed under atm. |
I hate to be that guy, but just bumping this back to the notifications area... |
@chabad360 Could you document what this code actually does? From what I can tell, it looks for either a pull request event, or a push.
How are you planning on using this? With GitHub? How would someone configure this? What would the workflow be? |
Yes.
Exactly the same way you do already.
Checkout chabad360/chabad360.github.io, a single poster blog, adds image optimization to everything on build. |
I'd love to see that super-useful feature merged back upstream! Looks like you did a good job @chabad360 ! 😃👍 |
This is now possible with |
Thanks @benschwarz. I was able to do what I was looking for at: kdeldycke/meta-package-manager@6f86f61 |
Hey @kdeldycke Just so you're aware, we made the compression report available in the So one potential improvement would be this to add an So something like this: ...
- uses: calibreapp/image-actions@1.1.0
id: calibre
...
body: >
[Auto-generated on run
#${{ github.run_id }}](https://github.com/${{ github.repository
}}/actions/runs/${{ github.run_id }}) as defined by [workflow
action](https://github.com/${{ github.repository
}}/blob/${{ github.base_ref }}/.github/workflows/autofix.yaml).%0A${{ steps.calibre.outputs.markdown }}
... Note I'm using You can see an example of this here. |
Oh. That's very nice! Thanks @bazzadp for the tip! 😃 |
This is a PR to fix #27. It would allow for using image-actions in a push-triggred workflow.