Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose significantCompressionPercent for user config #34

Conversation

reidab
Copy link

@reidab reidab commented Dec 17, 2019

We'd like to be able to configure the percentage compression that's considered significant to avoid some images being double-compressed on subsequent PRs.

@benschwarz
Copy link
Member

Thanks for sharing this @reidab. This seems like a pretty reasonable change to make. I was interested in learning what percentage you've set this to on your repositories?

Because image-actions is perhaps best when it's turned on and forgotten about, I wonder if it'd be useful to change the default percentage, rather than making it configurable. Keen to hear your thoughts on this.

@chabad360
Copy link
Contributor

@benschwarz I could see this being useful, especially if #30 merged since a lot of metrics want maximum compression possible, even if it's only 1-2% it would still be helpfull.

Also, this is going to need to be modified now the #29 was merged...

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@benschwarz benschwarz deleted the branch calibreapp:master February 1, 2022 02:31
@benschwarz benschwarz closed this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants