[Calyx-Backend] Use Morty to link external libraries #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiahanxie353
force-pushed
the
morty-multi-file
branch
from
cdcfb9c to
5c6d93e
Compare
ekiwi
reviewed
Dec 18, 2024
| morty.flush()?; | ||
|
|
||
| // Invoke Morty | ||
| let cmd = Command::new("morty") |
There was a problem hiding this comment.
Have you considered including morty as a Rust crate instead of launching it as an external binary? With a crate, then the user would not have to install it.
There was a problem hiding this comment.
morty is available on crates.io: https://crates.io/crates/morty
I have not investigated the API though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is the first half of #1928
We use Morty: https://github.com/pulp-platform/morty to pickle Verilog/System Verilog files needed as libraries.
Acknowledgement to @evanmwilliams for the original implementation.