feat(client): add replace menu shortcut

Closes #3332
camunda · Jan 2, 2023 · c5533ed · c5533ed
1 parent b45aef6
commit c5533ed
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/client/src/app/KeyboardBindings.js b/client/src/app/KeyboardBindings.js
@@ -60,6 +60,7 @@ export default class KeyboardBindings {
     this.paste = null;
     this.selectAll = null;
     this.removeSelection = null;
+    this.replaceElement = null;
     this.undo = null;
     this.redo = null;
 
@@ -136,6 +137,11 @@ export default class KeyboardBindings {
       action = getAction(this.redo);
     }
 
+    // replace
+    if (isKey([ 'r', 'R' ], event) && isEnabled(this.replaceElement)) {
+      action = getAction(this.replaceElement);
+    }
+
     // custom
     if (this.hasCustomEntry(event)) {
       action = this.getCustomAction(event, 'keydown');
@@ -199,7 +205,7 @@ export default class KeyboardBindings {
     this.selectAll = findSelectAll(menu);
     this.undo = findUndo(menu);
     this.redo = findRedo(menu);
-
+    this.replaceElement = findReplaceElement(menu);
     this.updateCustomEntries(menu);
 
     return menu;
@@ -425,6 +431,10 @@ function findSelectAll(menu) {
   return find(menu, ({ accelerator }) => isAccelerator(accelerator, 'CommandOrControl+A'));
 }
 
+function findReplaceElement(menu) {
+  return find(menu, ({ accelerator }) => isAccelerator(accelerator, 'R'));
+}
+
 /**
  * Check wether entry is enabled. If not specified it is enabled.
  *

diff --git a/client/src/app/__tests__/KeyboardBindingsSpec.js b/client/src/app/__tests__/KeyboardBindingsSpec.js
@@ -343,6 +343,25 @@ describe('KeyboardBindings', function() {
   });
 
 
+  it('replaceElement', function() {
+
+    // given
+    event = createKeyEvent('R');
+
+    keyboardBindings.update([ {
+      accelerator: 'R',
+      action: 'replaceElement'
+    } ]);
+
+    // when
+    keyboardBindings._keyDownHandler(event);
+
+    // then
+    expect(actionSpy).to.have.been.calledWith(null, 'replaceElement');
+
+  });
+
+
   it('#setOnAction', function() {
 
     // given