-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate new replace menu #3332
Comments
@smbea To consider if we want to do this (+ keyboard shortcut). |
Basically this means bumping versions and adding the keyboard shortcut, right? |
Yes. The keyboard shortcut may be missing with stock bpmn-js (yet). Did we add it? On the electron side of things we need to add it as a menu item, in addition. |
We haven't added it yet in bpmn-js, no. It is at the end of the checklist here bpmn-io/bpmn-js#1627 but since we decided to ship just replace, it should've been split up too oops |
Could you split up that monstrous issue up in two parts (ship replace + rest) @smbea? Makes it easier to follow along and not miss out on such things. |
Question: The 'R' shortcut overlaps with the token simulation reset shortcut. Isn't this something we should avoid? |
Let's not care about the token simulation R shortcut for the moment, but rather move forward at the core. Token simulation (similar to all other extensions) have to adopt. I.e. could decide to ditch the shortcut or use a different one to ensure 100% interoperability. A simple way to solve this is by making
|
What should we do?
R
) to replace currently selected elementWhy should we do it?
Support bpmn-io/bpmn-js#1627.
The text was updated successfully, but these errors were encountered: