-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't build on MacOS 10.15 Catalina #1529
Comments
Updating the electron-builder to the latest version ( FAILURE Error: invalid comment length. expected: 55271. found: 0
at /Users/niklas.kiefer/bpmn-io/camunda-modeler/node_modules/yauzl/index.js:133:25
at /Users/niklas.kiefer/bpmn-io/camunda-modeler/node_modules/yauzl/index.js:631:5
at Immediate.<anonymous> (/Users/niklas.kiefer/bpmn-io/camunda-modeler/node_modules/fd-slicer/index.js:202:5)
at runCallback (timers.js:705:18)
at tryOnImmediate (timers.js:676:5)
at processImmediate (timers.js:658:5) Indeed, the zipping seems to be still broken: |
Yes, the zip files problem has not been fixed yet: electron-userland/electron-builder#3534 |
This is not a critical issue for us as long as releases can still be built our releases on Travis. As it looks like Travis still uses 10.12 so we are fine (cf. build log). It is annoying and a potential time sink, though, as our Mac developers cannot test the built app anymore. @pinussilvestrus You mentioned a manual workaround, could you investigate if that exists / works for the time being? |
Sure, I'll check this soon. |
So the manual workaround for fixing the
LOL Anyway, what currently would work by upgrading the So I think, as it is currently possible for us, the Mac Developers, to build the application locally by upgrading the If you guys think we should do an intermediate step by updating to |
A new pre-release version of the build tools are published ( Maybe, but don't know for sure, adding a notarization could touch this one as well. |
As of `electron-builder@20.38.2`, the built zip files has been incorrect. On the other hand, older versions of `electron-builder` are unable to build application on MacOS 10.15 Catalina. Due to above, this commit removes `zip` from MacOS targets and adds a script that adds the built application to a correct zip archive. Related electron-userland/electron-builder#3534 Closes #1529
As of `electron-builder@20.38.2`, the built zip files has been incorrect. On the other hand, older versions of `electron-builder` are unable to build application on MacOS 10.15 Catalina. Due to above, this commit removes `zip` from MacOS targets and adds a script that adds the built application to a correct zip archive. Related electron-userland/electron-builder#3534 Closes #1529
As of `electron-builder@20.38.2`, the built zip files has been incorrect. On the other hand, older versions of `electron-builder` are unable to build application on MacOS 10.15 Catalina. Due to above, this commit removes `zip` from MacOS targets and adds a script that adds the built application to a correct zip archive. Related electron-userland/electron-builder#3534 Closes #1529
As of `electron-builder@20.38.2`, the built zip files has been incorrect. On the other hand, older versions of `electron-builder` are unable to build application on MacOS 10.15 Catalina. Due to above, this commit removes `zip` from MacOS targets and adds a script that adds the built application to a correct zip archive. Related electron-userland/electron-builder#3534 Closes #1529
As of `electron-builder@20.38.2`, the built zip files has been incorrect. On the other hand, older versions of `electron-builder` are unable to build application on MacOS 10.15 Catalina. Due to above, this commit removes `zip` from MacOS targets and adds a script that adds the built application to a correct zip archive. Related electron-userland/electron-builder#3534 Closes #1529
As of `electron-builder@20.38.2`, the built zip files has been incorrect. On the other hand, older versions of `electron-builder` are unable to build application on MacOS 10.15 Catalina. Due to above, this commit removes `zip` from MacOS targets and adds a script that adds the built application to a correct zip archive. Related electron-userland/electron-builder#3534 Closes #1529
As of `electron-builder@20.38.2`, the built zip files has been incorrect. On the other hand, older versions of `electron-builder` are unable to build application on MacOS 10.15 Catalina. Due to above, this commit removes `zip` from MacOS targets and adds a script that adds the built application to a correct zip archive. Related electron-userland/electron-builder#3534 Closes #1529
Same issue. Upgrading |
I can't build the app on MacOS anymore due to
Can't locate Mac/Memory.pm in @INC (you may need to install the Mac::Memory module)
.Related: electron-userland/electron-builder#3990
Describe the Bug
Log
Steps to Reproduce
npm run all
Expected Behavior
App builds.
Environment
develop
, any in factChild of #1584
The text was updated successfully, but these errors were encountered: