Migrate to MacOS Catalina #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
barmac
force-pushed
the
1572-catalina-fix
branch
5 times, most recently
from
f9a6a15
to
3a50148
Compare
|
The actual publishing jobs are available here: https://travis-ci.org/camunda/camunda-modeler/builds/611909768 Tested on both MacOS Mojave (10.14.6) and MacOS Catalina (10.15.1). Notarized build is already available as nightly. Non-release builds will not be notarized. |
bpmn-io-tasks
bot
added
needs review
barmac
force-pushed
the
1572-catalina-fix
branch
from
3a50148
to
e6cd58c
Compare
|
|
nikku
force-pushed
the
1572-catalina-fix
branch
from
e6cd58c
to
ebf5df1
Compare
As of `electron-builder@20.38.2`, the built zip files has been incorrect. On the other hand, older versions of `electron-builder` are unable to build application on MacOS 10.15 Catalina. Due to above, this commit removes `zip` from MacOS targets and adds a script that adds the built application to a correct zip archive. Related electron-userland/electron-builder#3534 Closes #1529
nikku
force-pushed
the
1572-catalina-fix
branch
from
ebf5df1
to
89a16ef
Compare
|
Works on Arch Linux, too. |
|
@philippfromme Can you quick check if the distribution still works on Windows, too? |
|
Works on Windows 👏 |
|
Good work @barmac 🚲. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1529
Closes #1572
Closes #1584