Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Element documentation section within a templated activity #4037

Closed
bastiankoerber opened this issue Dec 19, 2023 · 18 comments · Fixed by #4094 or #4154
Closed

Support Element documentation section within a templated activity #4037

bastiankoerber opened this issue Dec 19, 2023 · 18 comments · Fixed by #4094 or #4154
Assignees
Labels
Camunda 7 Flags an issue as related to Camunda Automation Platform 7 Camunda 8 Flags an issue as related to Camunda 8 channel:support element templates enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@bastiankoerber
Copy link

bastiankoerber commented Dec 19, 2023

Problem you would like to solve

As a user, I can attach element documentation to each component, except connectors. This limitation is causing dissatisfaction among business users.

Consider this scenario: Business users are incorporating functional requirements into their BPMN files, using them both for developers to understand the requirements and as part of the documentation. This is achieved through element documentation. However, when a developer takes over and converts some of these empty or service elements into connectors, a problem arises. The business specifications attached to these elements are lost in the case of both custom and out-of-the-box connectors.

Proposed solution

Add the element documentation field to connectors as well.

Not in scope and just FYI
(Additional conversation started => Add element documentation to Web Modeler Design tab: https://camunda.slack.com/archives/C0693F1NFK5/p1702991078456759)

Alternatives considered

using comments => Not accepted at least by one customer => https://jira.camunda.com/browse/SUPPORT-19345.
They see comments as a conversation and not as a space for defined business requirements.

Additional context

Related to SUPPORT-19345
Related to SUPPORT-17421

Mentioned in user interview.

@bastiankoerber bastiankoerber added the enhancement New feature or request label Dec 19, 2023
@bastiankoerber
Copy link
Author

@nikku nikku changed the title Support Element Documentation for Connectors as well. Support Element documentation section within a templated activity Dec 19, 2023
@nikku
Copy link
Member

nikku commented Dec 19, 2023

To better understand your feature request: What exactly would you like to accomplish:

  • As an element template author you can define if the Documentation field shall be shown or
  • The documentation field always shows, regardless of your template definition?

@ingorichtsmeier
Copy link

My personal preference: Show the field always, with an option to disable it in JSON Config for certain templates/or in all templates of this organization.
And it would be good to have an option to configure the position. Sometimes the field should be at the top, sometimes at the bottom of the property panel, sometime in the middle.

@nikku
Copy link
Member

nikku commented Jan 2, 2024

We'll likely not be able to provide full customization options (regarding placing) @ingorichtsmeier.

Your suggestion regarding a sensible default (+ override it per template) makes sense to me.

@nikku nikku added backlog Queued in backlog good first issue Good for newcomers labels Jan 2, 2024
@nikku
Copy link
Member

nikku commented Jan 2, 2024

Moving to backlog for the time being @bastiankoerber. If there is any particular urgency on this item, please bump it.

@bastiankoerber
Copy link
Author

Moving to backlog for the time being @bastiankoerber. If there is any particular urgency on this item, please bump it.

it will be important for this epic: https://github.com/camunda/product-hub/issues/2027 to have the same UX for all elements
@crobbins215 FYI

@CatalinaMoisuc CatalinaMoisuc added ready Ready to be worked on and removed backlog Queued in backlog labels Jan 16, 2024
@marstamm
Copy link
Member

Displaying it always is an easy pick, while hiding it optionally requires some more work.

I propose to make progress now, we simply show the documentation always and handle configuration in a follow-up

@nikku
Copy link
Member

nikku commented Jan 16, 2024

@marstamm We already have entriesVisible as a way to define what is shown to the user.

In C7 you can use exactly that mechanism to show (or hide) the documentation section.

@marstamm
Copy link
Member

marstamm commented Jan 16, 2024

@nikku
Copy link
Member

nikku commented Jan 16, 2024

Yea, my bad. It was a boolean or a string[] in properties-panel@0. If it is a string[] then it denotes the list of default entries to be shown with the template.

@marstamm
Copy link
Member

With some research, you might be thinking of the entriesVisible like this:

"entriesVisible" : {
   "_all": true
}

This mechanism was only available in properties panel 0.x and has not been available for some time

@nikku
Copy link
Member

nikku commented Jan 16, 2024

Exactly. But customers ask for it now (again).

@nikku
Copy link
Member

nikku commented Jan 16, 2024

The point I'm making is: We solved this in the past, by giving element template authors control over what they want to show. It was powerful, and it will be powerful as a feature again, while being simple in implementation.

@marstamm
Copy link
Member

As I understand this FR, the users don't want to configure anything, they just want a sensible default that allows for documentation on connectors. I think this makes sense as we also show the general and multi-instance sections without any configuration.

If we want to re-enable the old entriesVisible behavior and be consistent (default = hidden), we would have to update all connectors to achieve the behavior we want to achieve

@nikku
Copy link
Member

nikku commented Jan 16, 2024

As I understand this FR, the users don't want to configure anything

Got it, then let's make it so and await user feedback.

marstamm added a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Jan 16, 2024
@barmac
Copy link
Collaborator

barmac commented Jan 16, 2024

Some time ago we enabled the connector users to configure multiinstance characteristics as it is a feature specific to the diagram and not the element type. I believe the same applies to the documentation. Any BPMN element can be documented, and this should apply also to connectors. I don't see a reason why one should configure whether documentation is allowed for the same reason why connector template should not determine element's name.

@marstamm marstamm added the fixed upstream Requires integration of upstream change label Jan 18, 2024 — with bpmn-io-tasks
@marstamm marstamm removed the ready Ready to be worked on label Jan 18, 2024
nikku added a commit that referenced this issue Feb 2, 2024
Closes #4035
Closes #3070
Closes #4070
Closes #4051
Closes #4037
Closes #3991
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 2, 2024
@nikku nikku closed this as completed in a48f2db Feb 5, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 5, 2024
@nikku nikku added Camunda 8 Flags an issue as related to Camunda 8 Camunda 7 Flags an issue as related to Camunda Automation Platform 7 labels Feb 19, 2024
@nikku nikku reopened this Feb 22, 2024
@nikku
Copy link
Member

nikku commented Feb 22, 2024

Re-opening this as we want the same for Camunda 7, cf. SUPPORT-17421.

@nikku nikku added channel:support ready Ready to be worked on labels Feb 22, 2024
nikku added a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Feb 22, 2024
nikku added a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Feb 22, 2024
@nikku nikku added the fixed upstream Requires integration of upstream change label Feb 23, 2024 — with bpmn-io-tasks
@nikku nikku removed the ready Ready to be worked on label Feb 23, 2024
@nikku
Copy link
Member

nikku commented Feb 23, 2024

Additional fix for Camunda 7 element templates coming in via bpmn-io/bpmn-js-element-templates#67.

nikku added a commit that referenced this issue Feb 23, 2024
deps: update to `bpmn-js-element-templates@1.14.0`

  Closes #4037
  Closes #3622

deps: update to `bpmn-js@17.0.2`

deps: update to `diagram-js@14.1.0`
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Feb 23, 2024
nikku added a commit that referenced this issue Feb 26, 2024
deps: update to `bpmn-js-element-templates@1.14.0`

  Closes #4037
  Related to #3622

deps: update to `bpmn-js@17.0.2`

deps: update to `diagram-js@14.1.0`
@nikku nikku closed this as completed in 7ad03a8 Feb 26, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Camunda 7 Flags an issue as related to Camunda Automation Platform 7 Camunda 8 Flags an issue as related to Camunda 8 channel:support element templates enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants