Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump BPMN deps #4094

Merged
merged 8 commits into from
Feb 5, 2024
Merged

Bump BPMN deps #4094

merged 8 commits into from
Feb 5, 2024

Conversation

nikku
Copy link
Member

@nikku nikku commented Feb 2, 2024 •
edited
Loading

Closes #4035
Closes #4070
Closes #4051
Closes #4037
Closes #3991
Closes #3895

Related to #3070

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Feb 2, 2024
@nikku
Copy link
Member Author

nikku commented Feb 2, 2024

This PR is currently blocked as it fails locally (and in the distribution) with the following error message:

ERROR client omit is not a function
    at ../node_modules/bpmnlint-plugin-camunda-compat/index.js (webpack://camundanode_modules/bpmnlint-plugin-camunda-compat/index.js:37:0)
    at __webpack_require__ (webpack://camunda-modeler-client/webpack/bootstrap:19:0)
    at __webpack_require__.t (webpack:/camunda-modeler-client/webpack/runtime/create fake namespace object:10:0)
    at async (webpack://camundanode_modules/@camunda/linting/lib/Linter.js:145:0)
    at async (webpack://camundanode_modules/@camunda/linting/lib/Linter.js:73:0)
    at async (webpack://camunda-modeler-client/src/app/App.js:945:0)
    at async file:///home/nikku/camunda/projects/bpmn.io/camunda-modeler/client/build/bundle.js:78366:14

@philippfromme
Copy link
Contributor

This PR is currently blocked as it fails locally (and in the distribution) with the following error message:

ERROR client omit is not a function
    at ../node_modules/bpmnlint-plugin-camunda-compat/index.js (webpack://camundanode_modules/bpmnlint-plugin-camunda-compat/index.js:37:0)
    at __webpack_require__ (webpack://camunda-modeler-client/webpack/bootstrap:19:0)
    at __webpack_require__.t (webpack:/camunda-modeler-client/webpack/runtime/create fake namespace object:10:0)
    at async (webpack://camundanode_modules/@camunda/linting/lib/Linter.js:145:0)
    at async (webpack://camundanode_modules/@camunda/linting/lib/Linter.js:73:0)
    at async (webpack://camunda-modeler-client/src/app/App.js:945:0)
    at async file:///home/nikku/camunda/projects/bpmn.io/camunda-modeler/client/build/bundle.js:78366:14

Weird. We've been using omit in there for forever. 🤔

@nikku nikku marked this pull request as ready for review February 2, 2024 15:45
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 2, 2024
@nikku nikku requested review from a team, philippfromme and marstamm and removed request for a team February 2, 2024 15:45
@nikku
Copy link
Member Author

nikku commented Feb 2, 2024

Found during integration testing the changes: #4098.

philippfromme
philippfromme approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍🏻

@nikku nikku merged commit dda17a2 into develop Feb 5, 2024
12 checks passed
@nikku nikku deleted the bump-bpmn-deps branch February 5, 2024 11:09
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

@marstamm marstamm Awaiting requested review from marstamm marstamm was automatically assigned from camunda/modeling-dev

Assignees

@nikku nikku

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nikku @philippfromme