Resolve plug-in assets via logical paths #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
nikku
force-pushed
the
1135-logical-plugin-paths
branch
from
354589b
to
03b5607
Compare
|
Test case attached via 03b5607:
|
nikku
force-pushed
the
1135-logical-plugin-paths
branch
2 times, most recently
from
469a124
to
e889f2c
Compare
* ensure we don't fail if individual plug-in fails to load * add detailed logging of what is going on * enforce presence and uniqueness of plug-in names * store plug-ins in map (rather than array), by name
Resolve plug-in assets requested via a logical name
app-plugins://${name}${assetPath}
using the appropriate actual plug-in base.
Closes #1135
barmac
force-pushed
the
1135-logical-plugin-paths
branch
from
e889f2c
to
9e70dd9
Compare
|
Rebased on master. |
Previously, registration test would depend on the plugins fixtures directory. This would make it break whenever a valid plugin is added to the directory.
Parsing the asset path is moved to plugins module. The mechanism remains the same, but it's easier to test it now.
Previously, cat image would be present even in distro builds.
|
I moved the cat to a plugin. It should replace the loading logo as soon as client plugins implementation is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #1136 and adds the ability to resolve plug-in assets via logical names.
Closes #1135