Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve plug-in assets via logical paths #1137

Merged
merged 10 commits into from
Jan 24, 2019
Merged

Resolve plug-in assets via logical paths #1137

merged 10 commits into from
Jan 24, 2019

Commits on Jan 24, 2019

  1. chore(app): ES6ify entry point

    @nikku @barmac
    nikku authored and barmac committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    130a853 View commit details
    Browse the repository at this point in the history

  2. chore(plugins): rewrite back-end 

    * ensure we don't fail if individual plug-in fails to load
* add detailed logging of what is going on
* enforce presence and uniqueness of plug-in names
* store plug-ins in map (rather than array), by name
    @nikku @barmac
    nikku authored and barmac committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    f600951 View commit details
    Browse the repository at this point in the history

  3. chore(app): include test plug-in in DEV mode

    @nikku @barmac
    nikku authored and barmac committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    2a89169 View commit details
    Browse the repository at this point in the history

  4. feat(app): resolve plug-in assets via logical names 

    Resolve plug-in assets requested via a logical name

  app-plugins://${name}${assetPath}

using the appropriate actual plug-in base.

Closes #1135
    @nikku @barmac
    nikku authored and barmac committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    7032a03 View commit details
    Browse the repository at this point in the history

  5. test(plugins): verify logical name resolution

    @nikku @barmac
    nikku authored and barmac committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    2b4b14e View commit details
    Browse the repository at this point in the history

  6. test(app): only test files in <spec>

    @nikku @barmac
    nikku authored and barmac committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    e4aaa20 View commit details
    Browse the repository at this point in the history

  7. test(plugins): verify plug-in loading

    @nikku @barmac
    nikku authored and barmac committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    9e70dd9 View commit details
    Browse the repository at this point in the history

  8. test(plugins): separate fixtures 

    Previously, registration test would depend on the plugins
fixtures directory. This would make it break whenever a valid
plugin is added to the directory.
    @barmac
    barmac committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    987347e View commit details
    Browse the repository at this point in the history

  9. chore(plugins): parse plugin assets path inside plugins 

    Parsing the asset path is moved to plugins module. The mechanism
remains the same, but it's easier to test it now.
    @barmac
    barmac committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    59bdcf7 View commit details
    Browse the repository at this point in the history

  10. fix(client): move cat picture to dev plugin 

    Previously, cat image would be present even in distro builds.
    @barmac
    barmac committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    31ef720 View commit details
    Browse the repository at this point in the history