Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate + bundle license book #1270

Merged
merged 8 commits into from
Feb 26, 2019
Merged

Generate + bundle license book #1270

merged 8 commits into from
Feb 26, 2019

Conversation

nikku
Copy link
Member

@nikku nikku commented Feb 25, 2019 •
edited
Loading

This builds upon #1272 and hooks license book bundling into our release procedures.

TLDR

License book...

  • is checked into project as THIRD_PARTY_NOTICES file
  • is updated as prerelease script
  • is packed into distribution as THIRD_PARTY_NOTICES.camunda-modeler.txt

Visual Flow

image

Closes #1233

@ghost ghost assigned nikku Feb 25, 2019
@ghost ghost added the needs review Review pending label Feb 25, 2019
@nikku nikku mentioned this pull request Feb 25, 2019
Closed
3 tasks
@nikku nikku force-pushed the 1233-bundle-license-book branch 2 times, most recently from 018dac5 to f89e401 Compare February 25, 2019 13:31
@nikku nikku requested a review from barmac February 25, 2019 13:33
@nikku nikku changed the title WIP Generate + bundle license book Generate + bundle license book Feb 26, 2019
@ghost ghost assigned barmac Feb 26, 2019
barmac
barmac approved these changes Feb 26, 2019
View reviewed changes
Copy link
Collaborator

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff.

@barmac barmac merged commit 9d97430 into master Feb 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the 1233-bundle-license-book branch February 26, 2019 08:41
@ghost ghost removed the needs review Review pending label Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

Assignees

@nikku nikku

@barmac barmac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikku @barmac