fix(overlay): adjust max heights to always fit viewport #2915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smbea
commented
Apr 11, 2022
| @@ -27,7 +27,6 @@ export function ReportFeedbackOverlay(props) { | |||
| <Overlay | |||
| anchor={ props.anchor } | |||
| onClose={ props.onClose } | |||
| maxHeight="calc(100vh - 250px)" | |||
There was a problem hiding this comment.
Explanation: this was causing the the report feedback overlay to shorten and have scroll, even though there was plenty of space still. The height of this overlay is a lot smaller than MIN_HEIGHT of the Modeler, meaning we don't need to set this.
smbea
requested review from
a team,
philippfromme,
MaxTru and
andreasgeier
and removed request for
a team
andreasgeier
suggested changes
Apr 11, 2022
bpmn-io-tasks
bot
added
in progress
|
Expected: Screen.Recording.2022-04-11.at.17.30.39.mov |
smbea
force-pushed
the
2882-overlay-overflow
branch
from
0e468b1
to
0728720
Compare
|
@andreasgeier I updated the screen recording accordingly |
smbea
added
needs review
pinussilvestrus
suggested changes
Apr 19, 2022
bpmn-io-tasks
bot
added
in progress
smbea
force-pushed
the
2882-overlay-overflow
branch
from
0728720
to
d52ff9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2882
Screen.Recording.2022-04-12.at.14.29.50.mov