Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overlay): adjust max heights to always fit viewport #2915

Merged
merged 1 commit into from
Apr 19, 2022
Merged

fix(overlay): adjust max heights to always fit viewport #2915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion client/src/plugins/report-feedback/ReportFeedbackOverlay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ export function ReportFeedbackOverlay(props) {
<Overlay
anchor={ props.anchor }
onClose={ props.onClose }
maxHeight="calc(100vh - 250px)"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation: this was causing the the report feedback overlay to shorten and have scroll, even though there was plenty of space still. The height of this overlay is a lot smaller than MIN_HEIGHT of the Modeler, meaning we don't need to set this.

offset={ OFFSET }
className={ css.ReportFeedbackOverlay }
>
Expand Down
7 changes: 5 additions & 2 deletions client/src/shared/ui/overlay/Overlay.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,10 @@

fieldset {
border: none;
margin: 0 0 5px 0;
padding: 0;
margin: 0 -12px 5px 0;
padding: 0 12px 0 0;
pinussilvestrus marked this conversation as resolved.
Show resolved Hide resolved
max-height: calc(100vh - 176px);
overflow-y: auto;
}

.fields {
Expand Down Expand Up @@ -113,6 +115,7 @@

ul.dashed {
list-style: none;
max-height: calc(100vh - 250px);

li {
margin-bottom: 4px;
Expand Down