Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
614: fix: implement InMemoryLogStorage.append r=korthout a=korthout ## Description <!-- Please explain the changes you made here. --> This method was newly added to LogStorage to support appends of unserialized application data. But now this lead to a compilation error in ZPT because it contains a class `InMemoryLogStorage` that implements `LogStorage`. The [implementation of the test class ListLogStorage](https://github.com/camunda/zeebe/blob/4dd1025f3f3ba86b5aec10d380b9db8550ed0967/logstreams/src/test/java/io/camunda/zeebe/logstreams/util/ListLogStorage.java#L77-L79) seemed like a reasonable solution for zeebe-process-test. It simply writes the contents of the writer into a buffer and appends it as usual. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #613 <!-- Cut-off marker _All lines under and including the cut-off marker will be removed from the merge commit message_ ## Definition of Ready Please check the items that apply, before requesting a review. You can find more details about these items in our wiki page about [Pull Requests and Code Reviews](https://github.com/camunda-cloud/zeebe/wiki/Pull-Requests-and-Code-Reviews). * [x] I've reviewed my own code * [x] I've written a clear changelist description * [x] I've narrowly scoped my changes * [x] I've separated structural from behavioural changes --> ## Definition of Done <!-- Please check the items that apply, before merging or (if possible) before requesting a review. --> _Not all items need to be done depending on the issue and the pull request._ Code changes: * [x] The changes are backwards compatibility with previous versions * [ ] If it fixes a bug then PRs are created to backport the fix Testing: * [x] There are unit/integration tests that verify all acceptance criterias of the issue * [ ] New tests are written to ensure backwards compatibility with further versions * [ ] The behavior is tested manually Documentation: * [ ] Javadoc has been written * [ ] The documentation is updated Co-authored-by: Nico Korthout <nico.korthout@camunda.com>
- Loading branch information