fix: implement InMemoryLogStorage.append #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was newly added to LogStorage to support appends of unserialized application data. The implementation of the test class ListLogStorage seemed like a reasonable solution for zeebe-process-test. It simply writes the contents of the writer into a buffer and appends it as usual. See: https://github.com/camunda/zeebe/blob/4dd1025f3f3ba86b5aec10d380b9db8550ed0967/logstreams/src/test/java/io/camunda/zeebe/logstreams/util/ListLogStorage.java#L77-L79
korthout
requested review from
lenaschoenburg
and removed request for
remcowesterhoud
|
@oleschoenburg It might be better if you could review this one since you've also introduced the new API. |
lenaschoenburg
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Perfect, thanks @korthout! I keep forgetting that I have to update here when I make changes to the logstream.
|
@oleschoenburg No worries, that's what we have tests for. bors merge |
|
Build succeeded: |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This method was newly added to LogStorage to support appends of unserialized application data. But now this lead to a compilation error in ZPT because it contains a class
InMemoryLogStoragethat implementsLogStorage.The implementation of the test class ListLogStorage seemed like a reasonable solution for zeebe-process-test. It simply writes the contents of the writer into a buffer and appends it as usual.
Related issues
closes #613
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: