-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a test for SRIOV Intel NIC's (New) #1293
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
- Coverage 47.56% 46.03% -1.53%
==========================================
Files 369 359 -10
Lines 39596 39170 -426
Branches 6691 6633 -58
==========================================
- Hits 18833 18033 -800
- Misses 20051 20437 +386
+ Partials 712 700 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Adding SRIOV container tests Add flake8 format errors. Adding sriov tests to testing framework Fix the virtualizaion function call with the correct parameters Add Unit tests Update minor changes found by the Unit Testa Updated the unit tests for flake8 format Removed the call to setup. Setup is not called when the test runs on images less than 24.04
black reformating
As discussed earlier, the implementation of the virtualization/SRIOV test was outdated, duplicating a lot of code, and did not include enough unit tests. We will move this implementation to checkbox-support, but that PR is not yet in place. After discussing it with Max, we have decided that the best approach for the moment for the SRIOV tests is to move them away from virtualization.py tests. We should copy the implementation of the LXD/LXDVM classes from that PR and add the SRIOV functionalities over this new implementation (copy-paste the LXD/LXDVM without modifying them and inherit from them for the SRIOV tests). That way we can reuse the tests already in place for the LXD/LXDVM classes Once the LXD/LXDVM classes are in checkbox-support, we will create a new PR to import them from checkbox-support and remove the duplication. |
See #1645 |
The @mreed8855 You can find an example use of them in |
Description
Recently there was as request for sriov testcases. This PR provides a means to test Intel NIC's enabled with SRIOV. This tests
Note: It finds Mellanox devices but does not test them. That is TODO for a future PR
Resolved issues
Documentation
Tests