-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lxd gpu passthrough tests (New) #1535
Conversation
My list of things I still need to do before this can be merged:
There may be other items to still work on, but that's what I can think of at the moment |
7513533
to
9dced2b
Compare
I've added the test plan and jobs, but for some reason, the template doesn't find any jobs to run. Any ideas on what is going on? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1535 +/- ##
==========================================
+ Coverage 47.76% 57.14% +9.37%
==========================================
Files 370 1 -369
Lines 39750 42 -39708
Branches 6720 6 -6714
==========================================
- Hits 18987 24 -18963
+ Misses 20048 18 -20030
+ Partials 715 0 -715
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Will add the LXD VM test too, but I may refactor the code because I see a lot of code duplication between the LXDTest and LXDTest_vm classes...
I've also updated the coverage tests to pass with the new way the classes work.
Fallback to "native" option. See https://cmake.org/cmake/help/latest/prop_tgt/CUDA_ARCHITECTURES.html
Simplifies running commands on the LXD guest.
Also added coverage tests
Seems like overhead on Luma made the tests take much longer on average.
Refactored configuration step, extracting fucntions. This allows for easier overrides in the VM test.
CUDA toolkit failed to install on a VM due to lack of storage.
Disable secure boot to install NVIDIA drivers successfully while unattended
Using `--gpgpu` installs headless drivers that cuda-toolkit and mixbench can't seem to use.
In case ICMP does not work on the test machine.
Updated coverage tests, added more coverage tests too...
449645e
to
f675f9e
Compare
Was using invalid `name`
@fernando79513 Thinking this over, this PR could probably be closed and reopened. I don't see any hard reason why the GPU tests should live in the The only things I was using from this script were the run command wrapper, but that isn't a strong enough reason in my opinion. Let me know what you think. I just want to make your life easier with reviewing PRs. |
Closing this PR, the PR is way too large, and as discussed, it will be extracted to its own script. We will need to revisit refactoring |
Description
virtualization.py
to reduce code duplicationResolved issues
Documentation
n/a
Tests
NVIDIA tests run on Luma.
AMD tests run on my personal device (TODO: find a device to test these on)