fix: print proper estimated runtime even when some jobs don't provide it #435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by fix for the estimated duration computation that Pierre complained about yesterday.
With this patch, if a job exists that doesn't specify the estimated_duration, Checkbox will still compute the whole estimated runtime but it will add the "at least" clause.
I tested it by creating a provider with two jobs, one with a estimated_duration defined, and one that did not have it.
I've run sessions with varying selections to see if it works properly.