Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: print proper estimated runtime even when some jobs don't provide it #435

Merged
merged 1 commit into from
May 8, 2023
Merged

fix: print proper estimated runtime even when some jobs don't provide it #435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions checkbox-ng/checkbox_ng/launcher/stages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,29 +236,31 @@ def considering_job(self, job, job_state):
return CheckboxUI(self.C.c, show_cmd_output=show_out)

def _run_jobs(self, jobs_to_run):
# some jobs that are planned to be run don't have an
# estimated_duration defined, but we still want to keep track of
# the ones that do. if any of the job doesn't have it we have to
# add "at least" to the estimate
estimated_time = 0
had_unknown_time = False
for job_id in jobs_to_run:
job = self.sa.get_job(job_id)
if (job.estimated_duration is not None and
estimated_time is not None):
if job.estimated_duration is not None:
estimated_time += job.estimated_duration
else:
estimated_time = None
had_unknown_time = True
header = _("Running job {} / {}. Estimated time left{}: {}")
for job_no, job_id in enumerate(jobs_to_run, start=1):
print(self.C.header(
_('Running job {} / {}. Estimated time left: {}').format(
job_no, len(jobs_to_run),
seconds_to_human_duration(max(0, estimated_time))
if estimated_time is not None else _("unknown")),
fill='-'))
print(self.C.header(header.format(
job_no, len(jobs_to_run),
_(" (at least)") if had_unknown_time else "",
seconds_to_human_duration(estimated_time),
fill='-')))
job = self.sa.get_job(job_id)
builder = self._run_single_job_with_ui_loop(
job, self._get_ui_for_job(job))
result = builder.get_result()
self.sa.use_job_result(job_id, result)
if (job.estimated_duration is not None and
estimated_time is not None):
estimated_time -= job.estimated_duration
estimated_time -= job.estimated_duration or 0

def _run_bootstrap_jobs(self, jobs_to_run):
for job_no, job_id in enumerate(jobs_to_run, start=1):
Expand Down