Add support for free-standing loki rules and grafana dashboards #6
Conversation
sed-i
force-pushed
the
add-loki
branch
3 times, most recently
from
3ee7b9d
to
6454472
Compare
sed-i
changed the title
| description: URL to repo to sync against | ||
| git-sync::branch: | ||
| description: URL to repo to clone and sync against. | ||
| git_branch: |
There was a problem hiding this comment.
git_branch and git_rev are both defined and both needed. git-sync has defaults for both so we're good. Can provide git_rev and omit the branch. It's impossible to clone a revision - only after cloning a branch can checkout a revision.
| @@ -0,0 +1,280 @@ | |||
| # Copyright 2021 Canonical Ltd. | |||
There was a problem hiding this comment.
Actually I do not think we care to fix the K8s service at all: this charm does not expose any web api we care to invoke from the outside, and this makes us need —trust. I’d say we just don’t fix this K8s service instead.
There was a problem hiding this comment.
git-sync has http api for "health" and /metrics
|
Recent changes to prom and loki broke integration tests. |
sed-i
dismissed stale reviews from mmanciop and simskij
both branch and rev are needed.
sed-i
requested review from
simskij,
mmanciop,
rbarry82,
dstathis,
Abuelodelanada,
balbirthomas and
a team
TODO:
Depends on:
GrafanaDashboardProviderif the dashboard path cannot be resolved or is empty grafana-k8s-operator#53