add private method to reinitialize alerts #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed-i
requested review from
simskij,
balbirthomas,
dstathis,
rbarry82 and
a team
dstathis
previously approved these changes
Jan 24, 2022
10 tasks
mmanciop
previously requested changes
Jan 25, 2022
rbarry82
previously requested changes
Jan 25, 2022
sed-i
force-pushed
the
feature/refresh_alerts
branch
from
1c31e22
to
0e41df3
Compare
rbarry82
previously approved these changes
Jan 25, 2022
mmanciop
approved these changes
Jan 25, 2022
dstathis
approved these changes
Jan 25, 2022
rbarry82
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a private method for refreshing (re-initializing) relation data for alerts.
This is needed for cos-config to be able to refresh alerts when alerts show up on disk after the last hook fired.
cf. canonical/loki-k8s-operator#76, canonical/grafana-k8s-operator#53