Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] chore: refactor lifecycle commands #339

Closed
wants to merge 1 commit into from
Closed

[DRAFT] chore: refactor lifecycle commands #339

wants to merge 1 commit into from

Conversation

mr-cal
Copy link
Contributor

@mr-cal mr-cal commented May 2, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

A first attempt at refactoring the lifecycle commands to:

  1. Remove the parts argument from the pack command
  2. Add another pack command that can skip running the lifecycle

This prototype isn't working very well, especially because *craft pack has to load a project and *craft pack <directory> does not.

@mr-cal
chore: refactor lifecycle commands
7ee1215 
Signed-off-by: Callahan Kovacs <callahankovacs@gmail.com>
@mr-cal mr-cal marked this pull request as draft May 2, 2024 23:26
@mr-cal
Copy link
Contributor Author

mr-cal commented May 8, 2024

Closing in favor of #340

@mr-cal mr-cal closed this May 8, 2024
@mr-cal mr-cal deleted the work/pack-command-refactor branch May 8, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mr-cal