Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add needs_project property #340

Merged
merged 2 commits into from
May 8, 2024
Merged

feat: add needs_project property #340

merged 2 commits into from
May 8, 2024

Conversation

mr-cal
Copy link
Contributor

@mr-cal mr-cal commented May 7, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Two things:

  1. Refactors the LifecycleCommands classes in a slightly more organized way without changing any existing commands. This is required for snapcraft to define its own Pack command with minimal duplicated code (feat: allow packing a directory snapcraft#4794)
  2. Add a needs_project property, which can determine if a project needs to be loaded based on the provided arguments.

Fixes canonical/snapcraft#4769
(CRAFT-2861)

@mr-cal mr-cal force-pushed the work/needs-project branch from a458d89 to a4764a9 Compare May 7, 2024 22:20
@mr-cal mr-cal changed the title [DRAFT] feat: add needs_project property feat: add needs_project property May 8, 2024
@mr-cal mr-cal requested review from lengau and tigarmo and removed request for lengau May 8, 2024 16:33
@mr-cal mr-cal requested a review from tigarmo May 8, 2024 17:40
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks!

@mr-cal
Copy link
Contributor Author

mr-cal commented May 8, 2024

Force-pushing so I can rebase

mr-cal added 2 commits May 8, 2024 13:21
Signed-off-by: Callahan Kovacs <callahankovacs@gmail.com>
Signed-off-by: Callahan Kovacs <callahankovacs@gmail.com>
@mr-cal mr-cal force-pushed the work/needs-project branch from d26b016 to aaff7e2 Compare May 8, 2024 18:21
@mr-cal mr-cal merged commit 309aa73 into main May 8, 2024
6 checks passed
@mr-cal mr-cal deleted the work/needs-project branch May 8, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snapcraft 8.2.1: snapcraft pack not respecting <directory> arg to find snapcraft.yaml
3 participants