plugins: qmake #463
Merged
plugins: qmake #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
reviewed
May 25, 2023
There was a problem hiding this comment.
Thanks @ScarlettGatelyMoore, this looks great! I'd like @cmatsuoka to review this too since he's much more familiar with craft_parts than I am, but all my comments are pretty minor/nitpicky.
I've also enabled the CI runners here for tests and stuff.
|
@ScarlettGatelyMoore I'll take a look at the ruff stuff - it's probably due to problems with the configuration I made + ruff not being stable yet |
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
|
Great, Thanks! |
|
I made a PR to your branch that fixes the linting issues on my machine (and presumably in CI): ScarlettGatelyMoore#1 I think it'll fix the pytest import error too |
linting fixes
This reverts commit 5de8bba.
|
Who do I need to poke to get these workflows approved? |
|
@lengau @ScarlettGatelyMoore Any progress on this or any targeted release ? |
I got stuck and then time got away from me. I will take a look again this week. Or if another set of eyes can take a look, I don't oppose help. |
|
I made progress on this. The tests pass now except pyright fails on a bunch of doc type failures and are unrelated to this. |
cmatsuoka
reviewed
Aug 24, 2023
…nd shorten conditional.
…tional and shorten conditional." This reverts commit 143a9d0.
|
I've made a PR to your branch that should fix the relevant issues. |
lengau
approved these changes
Nov 20, 2023
cmatsuoka
approved these changes
Dec 19, 2023
linostar
pushed a commit
to linostar/craft-parts
that referenced
this pull request
Jan 2, 2024
Add support to qmake projects.
2 tasks
syu-w
referenced
this pull request
in canonical/charmcraft
Mar 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [craft-parts](https://github.com/canonical/craft-parts) | `==1.26.2` -> `==1.27.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>canonical/craft-parts (craft-parts)</summary> ### [`v1.27.0`](https://github.com/canonical/craft-parts/releases/tag/1.27.0) [Compare Source](https://github.com/canonical/craft-parts/compare/1.26.2...1.27.0) ##### What's Changed - chore(linter): enable ruff base on starbase config by [@​syu-w](https://github.com/syu-w) in [https://github.com/canonical/craft-parts/pull/580](https://github.com/canonical/craft-parts/pull/580) - chore(linter): ruff auto fix base on starbase config by [@​syu-w](https://github.com/syu-w) in [https://github.com/canonical/craft-parts/pull/581](https://github.com/canonical/craft-parts/pull/581) - chore(deps): update dependency pyright to v1.1.337 by [@​renovate](https://github.com/renovate) in [https://github.com/canonical/craft-parts/pull/588](https://github.com/canonical/craft-parts/pull/588) - chore(linter): misc fixes by [@​syu-w](https://github.com/syu-w) in [https://github.com/canonical/craft-parts/pull/585](https://github.com/canonical/craft-parts/pull/585) - feat(info): add base layer data to ProjectInfo by [@​tigarmo](https://github.com/tigarmo) in [https://github.com/canonical/craft-parts/pull/594](https://github.com/canonical/craft-parts/pull/594) - docs: add rockcraft chisel notes by [@​syu-w](https://github.com/syu-w) in [https://github.com/canonical/craft-parts/pull/587](https://github.com/canonical/craft-parts/pull/587) - chore(deps): update actions/setup-node action to v4 by [@​renovate](https://github.com/renovate) in [https://github.com/canonical/craft-parts/pull/586](https://github.com/canonical/craft-parts/pull/586) - chore(deps): update documentation dependencies by [@​renovate](https://github.com/renovate) in [https://github.com/canonical/craft-parts/pull/591](https://github.com/canonical/craft-parts/pull/591) - chore(deps): disable renovate on things we can't update by [@​lengau](https://github.com/lengau) in [https://github.com/canonical/craft-parts/pull/606](https://github.com/canonical/craft-parts/pull/606) - chore(deps): loosen mypy requirement by [@​lengau](https://github.com/lengau) in [https://github.com/canonical/craft-parts/pull/604](https://github.com/canonical/craft-parts/pull/604) - chore(deps): prevent renovate from updating types-requests by [@​lengau](https://github.com/lengau) in [https://github.com/canonical/craft-parts/pull/605](https://github.com/canonical/craft-parts/pull/605) - docs: add note about plugin-specific properties by [@​mr-cal](https://github.com/mr-cal) in [https://github.com/canonical/craft-parts/pull/608](https://github.com/canonical/craft-parts/pull/608) - plugins: qmake by [@​ScarlettGatelyMoore](https://github.com/ScarlettGatelyMoore) in [https://github.com/canonical/craft-parts/pull/463](https://github.com/canonical/craft-parts/pull/463) - plugins: ant: add proxy support by [@​kubiko](https://github.com/kubiko) in [https://github.com/canonical/craft-parts/pull/579](https://github.com/canonical/craft-parts/pull/579) - test: make tests work in python 3.12+ by [@​lengau](https://github.com/lengau) in [https://github.com/canonical/craft-parts/pull/617](https://github.com/canonical/craft-parts/pull/617) - chore(deps): update actions/setup-python action to v5 by [@​renovate](https://github.com/renovate) in [https://github.com/canonical/craft-parts/pull/615](https://github.com/canonical/craft-parts/pull/615) - Merge 1.26.1 by [@​cmatsuoka](https://github.com/cmatsuoka) in [https://github.com/canonical/craft-parts/pull/612](https://github.com/canonical/craft-parts/pull/612) - chore(ci): update chisel by [@​tigarmo](https://github.com/tigarmo) in [https://github.com/canonical/craft-parts/pull/622](https://github.com/canonical/craft-parts/pull/622) - test: use `new_dir` fixture by [@​mr-cal](https://github.com/mr-cal) in [https://github.com/canonical/craft-parts/pull/624](https://github.com/canonical/craft-parts/pull/624) - build(deps): pin overrides!=7.6.0 by [@​mr-cal](https://github.com/mr-cal) in [https://github.com/canonical/craft-parts/pull/628](https://github.com/canonical/craft-parts/pull/628) - fix(parts): set field defaults using default_factory by [@​thp-canonical](https://github.com/thp-canonical) in [https://github.com/canonical/craft-parts/pull/629](https://github.com/canonical/craft-parts/pull/629) - feat(rust_plugin): use `rustup` snap and more options by [@​liushuyu](https://github.com/liushuyu) in [https://github.com/canonical/craft-parts/pull/626](https://github.com/canonical/craft-parts/pull/626) - style: update to black 2024 by [@​mr-cal](https://github.com/mr-cal) in [https://github.com/canonical/craft-parts/pull/638](https://github.com/canonical/craft-parts/pull/638) - chore(deps): update dependency ruff to v0.1.14 by [@​renovate](https://github.com/renovate) in [https://github.com/canonical/craft-parts/pull/589](https://github.com/canonical/craft-parts/pull/589) - ci: update Chisel version again by [@​tigarmo](https://github.com/tigarmo) in [https://github.com/canonical/craft-parts/pull/642](https://github.com/canonical/craft-parts/pull/642) - style: update pyright by [@​lengau](https://github.com/lengau) in [https://github.com/canonical/craft-parts/pull/639](https://github.com/canonical/craft-parts/pull/639) - build: use tox for unit tests in CI by [@​lengau](https://github.com/lengau) in [https://github.com/canonical/craft-parts/pull/616](https://github.com/canonical/craft-parts/pull/616) - ci: use GH/JIRA integration bot by [@​sergiusens](https://github.com/sergiusens) in [https://github.com/canonical/craft-parts/pull/658](https://github.com/canonical/craft-parts/pull/658) - docs: Link filesets specification from part properties by [@​thp-canonical](https://github.com/thp-canonical) in [https://github.com/canonical/craft-parts/pull/654](https://github.com/canonical/craft-parts/pull/654) - tests: use a path in the user's home directory for xattrs tests by [@​lengau](https://github.com/lengau) in [https://github.com/canonical/craft-parts/pull/678](https://github.com/canonical/craft-parts/pull/678) - docs(plugins): add dump plugin docs by [@​syu-w](https://github.com/syu-w) in [https://github.com/canonical/craft-parts/pull/676](https://github.com/canonical/craft-parts/pull/676) - chore(deps): update documentation dependencies by [@​renovate](https://github.com/renovate) in [https://github.com/canonical/craft-parts/pull/643](https://github.com/canonical/craft-parts/pull/643) - chore(deps): update documentation dependencies (major) by [@​renovate](https://github.com/renovate) in [https://github.com/canonical/craft-parts/pull/644](https://github.com/canonical/craft-parts/pull/644) - chore(linter): refine ruff configurations by [@​liushuyu](https://github.com/liushuyu) in [https://github.com/canonical/craft-parts/pull/651](https://github.com/canonical/craft-parts/pull/651) - refactor(docs) move more docs to the shared base by [@​tigarmo](https://github.com/tigarmo) in [https://github.com/canonical/craft-parts/pull/680](https://github.com/canonical/craft-parts/pull/680) - Merge 1.26.2 by [@​cmatsuoka](https://github.com/cmatsuoka) in [https://github.com/canonical/craft-parts/pull/656](https://github.com/canonical/craft-parts/pull/656) - Release 1.27.0 by [@​cmatsuoka](https://github.com/cmatsuoka) in [https://github.com/canonical/craft-parts/pull/681](https://github.com/canonical/craft-parts/pull/681) ##### New Contributors - [@​ScarlettGatelyMoore](https://github.com/ScarlettGatelyMoore) made their first contribution in [https://github.com/canonical/craft-parts/pull/463](https://github.com/canonical/craft-parts/pull/463) - [@​kubiko](https://github.com/kubiko) made their first contribution in [https://github.com/canonical/craft-parts/pull/579](https://github.com/canonical/craft-parts/pull/579) - [@​thp-canonical](https://github.com/thp-canonical) made their first contribution in [https://github.com/canonical/craft-parts/pull/629](https://github.com/canonical/craft-parts/pull/629) **Full Changelog**: canonical/craft-parts@1.26.2...1.27.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/charmcraft). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzguMSIsInVwZGF0ZWRJblZlciI6IjM3LjIzOC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the make tests - but I am going to be honest and couldn't get past the ruff test. It wanted me to change a bunch of files that don't belong to me.