Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: Enable qmake for core22 #4162

Merged
merged 24 commits into from
Mar 12, 2024

Conversation

ScarlettGatelyMoore
Copy link
Contributor

  • [x ] Have you followed the guidelines for contributing?
  • [x ] Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

@lengau
Copy link
Contributor

lengau commented May 20, 2023

This seems to me like it would make sense upstream as a craft-parts plugin, since I can imagine wanting to use qmake for charms or rocks as well.

ScarlettGatelyMoore and others added 9 commits May 22, 2023 06:11
…lo/snap/snapcraft.yaml

Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
@ScarlettGatelyMoore
Copy link
Contributor Author

This seems to me like it would make sense upstream as a craft-parts plugin, since I can imagine wanting to use qmake for charms or rocks as well.

Thank you so much for the review. All changes applied!

@lengau
Copy link
Contributor

lengau commented May 23, 2023

Thanks for this, @ScarlettGatelyMoore ! It looks great, and I especially appreciate the spread test.

I spoke with @sergiusens this morning and he confirmed we should be putting the plugin itself into craft-parts. Could you move the Python code into a PR on craft-parts, but keep this PR open with the spread tests? That way we'll have upstream'd qmake support, but with a full e2e test here.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #4162 (67f0117) into main (bbd0a4e) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #4162      +/-   ##
==========================================
- Coverage   89.18%   89.17%   -0.02%     
==========================================
  Files         322      321       -1     
  Lines       21657    21608      -49     
==========================================
- Hits        19315    19268      -47     
+ Misses       2342     2340       -2     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@icotoi
Copy link

icotoi commented Sep 27, 2023

Any updates when this can be merged?

@patviafore-kudzera
Copy link

I'd also appreciate a merge, as I'm running into this issue as well. Can I help with anything that's blocking that people don't have time to dig into?

@lengau lengau self-requested a review February 29, 2024 04:26
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base (3e1d1b2) to head (494ea32).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4162   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files         328      328           
  Lines       22046    22046           
=======================================
  Hits        19483    19483           
  Misses       2563     2563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lengau
Copy link
Contributor

lengau commented Feb 29, 2024

Status report on this:

We need a release of craft-parts to include this PR. Then presuming the tests succeed (I don't see why they wouldn't) we can merge this.

@cmatsuoka how do you feel about a craft-parts 1.27 release? It looks like we'll get the qmake plugin, proxy support for ant, and using the rustup snap.

@lengau lengau requested a review from cmatsuoka February 29, 2024 20:11
@lengau lengau requested review from sergiusens and mr-cal March 8, 2024 23:36
@lengau lengau merged commit d2731f1 into canonical:main Mar 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants