-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins: Enable qmake for core22 #4162
Plugins: Enable qmake for core22 #4162
Conversation
This seems to me like it would make sense upstream as a craft-parts plugin, since I can imagine wanting to use qmake for charms or rocks as well. |
tests/spread/plugins/craft-parts/build-and-run-hello/qmake-hello/snap/snapcraft.yaml
Outdated
Show resolved
Hide resolved
…lo/snap/snapcraft.yaml Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Thank you so much for the review. All changes applied! |
Thanks for this, @ScarlettGatelyMoore ! It looks great, and I especially appreciate the spread test. I spoke with @sergiusens this morning and he confirmed we should be putting the plugin itself into craft-parts. Could you move the Python code into a PR on |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #4162 +/- ##
==========================================
- Coverage 89.18% 89.17% -0.02%
==========================================
Files 322 321 -1
Lines 21657 21608 -49
==========================================
- Hits 19315 19268 -47
+ Misses 2342 2340 -2 see 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Any updates when this can be merged? |
I'd also appreciate a merge, as I'm running into this issue as well. Can I help with anything that's blocking that people don't have time to dig into? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4162 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 328 328
Lines 22046 22046
=======================================
Hits 19483 19483
Misses 2563 2563 ☔ View full report in Codecov by Sentry. |
Status report on this: We need a release of @cmatsuoka how do you feel about a craft-parts 1.27 release? It looks like we'll get the qmake plugin, proxy support for ant, and using the |
make lint
?pytest tests/unit
?