refactor: add dex-issuer-url and remove public-url config options #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the public-url configuration option in favour of the dex-issuer-url one. The way to configure the issuer value for dex-auth is now by getting it from the aforementioned configuration option or by constructing it from dex-auths Kubernetes Service DNS name: "http://<dex-app-name>.<namespace>.svc:5556/dex" Closes #204
orfeas-k
reviewed
Jul 17, 2024
Comment on lines
+244
to
+246
| # FIXME: the correct behaviour should be to change the config | ||
| # at any point in time to trigger config events and check the | ||
| # value gets passed correctly when it changes. |
There was a problem hiding this comment.
I remember this discussion but do we have an issue for this? I mean if at some point there is a fix, we could link this.
There was a problem hiding this comment.
We do not have an issue, but also I'm not sure if there is a fix as this would be harness' behaviour. I can create one in our tracker just so we remember what it is and what are the things we have to do as workarounds.
There was a problem hiding this comment.
Let's if there is an issue in Harness. Otherwise, it's fine as is.
orfeas-k
approved these changes
Jul 23, 2024
This was referenced Jul 23, 2024
DnPlas
added a commit
that referenced
this pull request
Jul 24, 2024
* refactor: add dex-issuer-url and remove public-url config options This commit removes the public-url configuration option in favour of the dex-issuer-url one. The way to configure the issuer value for dex-auth is now by getting it from the aforementioned configuration option or by constructing it from dex-auths Kubernetes Service DNS name: "http://<dex-app-name>.<namespace>.svc:5556/dex" Closes #204
DnPlas
added a commit
that referenced
this pull request
Jul 25, 2024
This branch introduces changes to support the dex-oidc-config interface and the deprecation of public-url in favour of issuer-url. For more information, please refer to the following: * refactor: add dex-issuer-url and remove public-url config options (#209) * feat: add dex_oidc_config library (#208) * chore: keep public-url config option for compatibility #213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the public-url configuration option in favour of the dex-issuer-url one. The way to configure the issuer value for dex-auth is now by getting it from the aforementioned configuration option or by constructing it from dex-auths Kubernetes Service DNS name: "http://..svc:5556/dex"
Closes #204
Merge after #208 - CI is expected to fail until that PR is merged.
Testing instructions
juju config public-urldoes not allow to set the config option