feat: merge KF-5526-issuer-url-dev-branch into main #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgildein
previously approved these changes
Jul 24, 2024
* feat: add dex_oidc_config library Add a library to handle the dex-oidc-config relation interface. This library allows dex-auth to share its OIDC configuration with OIDC clients such as the oidc-gatekeeper charm. The library is designed to be extended to share any information about Dex, but right now it is only sharing Dex's issuer url. Closes #203
* refactor: add dex-issuer-url and remove public-url config options This commit removes the public-url configuration option in favour of the dex-issuer-url one. The way to configure the issuer value for dex-auth is now by getting it from the aforementioned configuration option or by constructing it from dex-auths Kubernetes Service DNS name: "http://<dex-app-name>.<namespace>.svc:5556/dex" Closes #204
Co-authored-by: Robert Gildein <gildeinrobert@gmail.com>
Since this is a breaking change, it is preferrable to keep some sort of compatibility that allow users with existing deployments to keep running Dex even after the upgrade. This configuration option can be removed after a deprecation notice is rolled out.
DnPlas
force-pushed
the
KF-5536-issuer-url-dev-branch
branch
from
ee0db14 to
f94ada1
Compare
rgildein
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes in
main:These changes were already tested in their individual PRs.