-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interrupt query yielding rows. #560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuBordere
force-pushed
the
interrupt
branch
2 times, most recently
from
February 5, 2024 12:38
dc5b55f
to
d7b0dd8
Compare
please test downstream |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
==========================================
+ Coverage 61.29% 61.31% +0.02%
==========================================
Files 34 34
Lines 6834 6838 +4
Branches 2031 2033 +2
==========================================
+ Hits 4189 4193 +4
+ Misses 1349 1345 -4
- Partials 1296 1300 +4 ☔ View full report in Codecov by Sentry. |
MathieuBordere
force-pushed
the
interrupt
branch
2 times, most recently
from
February 6, 2024 10:09
75de6d3
to
ab2ecff
Compare
please test downstream |
cole-miller
reviewed
Feb 7, 2024
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
MathieuBordere
force-pushed
the
interrupt
branch
from
February 7, 2024 14:41
ab2ecff
to
0976158
Compare
cole-miller
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooray!
MathieuBordere
pushed a commit
to MathieuBordere/dqlite
that referenced
this pull request
Feb 9, 2024
cole-miller
added a commit
that referenced
this pull request
Feb 9, 2024
Revert "Merge pull request #560 from MathieuBordere/interrupt"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to interrupt a query yielding rows, whereas in the past the interrupt request was only handled - after - all rows were returned.
To make this work I had to allow multiple pending writes to the transport because the query that's yielding rows is writing to the transport, but when an interrupt comes in, we also want the interrupt handler to be able to write to the transport. As long as messages are written as whole and
uv_write_t
doesn't interleave data of 2 writes [1] then this should be okay.DRAFT: running tests and upstream tests and also want to check if I'm violating some assumptions by allowing multiple writes, basically checking [1].
EDIT: writes with
uv_write_t
are queued and execute in order, so multiple writes should be fine. dqlite also sends data with message granularity, so that should also be fine.