Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #560 from MathieuBordere/interrupt" #570

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

MathieuBordere
Copy link
Contributor

This reverts commit 4ca4dae, reversing changes made to 71562ee.

Fix was buggy, needs a more thorough refactoring of request handling on a connection.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4ca4dae) 61.31% compared to head (ef7741e) 61.29%.

Files Patch % Lines
src/gateway.c 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
- Coverage   61.31%   61.29%   -0.03%     
==========================================
  Files          34       34              
  Lines        6838     6834       -4     
  Branches     2033     2031       -2     
==========================================
- Hits         4193     4189       -4     
- Misses       1345     1349       +4     
+ Partials     1300     1296       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cole-miller cole-miller merged commit 5e3128f into canonical:master Feb 9, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants