Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow builds without libdqlite #108

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

marco6
Copy link
Collaborator

@marco6 marco6 commented Jun 27, 2024

This PR aims at making it possible to go build . the project without libdqlite in the system. This is essential if we want to be able to test all project (i.e. run go test ./...).

@marco6 marco6 requested a review from a team as a code owner June 27, 2024 06:19
@marco6 marco6 marked this pull request as draft June 27, 2024 06:30
@marco6
Copy link
Collaborator Author

marco6 commented Jun 27, 2024

Depends on #109

@marco6
Copy link
Collaborator Author

marco6 commented Jul 1, 2024

Marking as ready since #109 was merged.

@marco6 marco6 marked this pull request as ready for review July 1, 2024 12:20
@marco6 marco6 requested a review from bschimke95 July 1, 2024 12:20
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marco6 marco6 merged commit a5bb191 into canonical:master Jul 1, 2024
8 of 9 checks passed
@marco6 marco6 deleted the sqlite-only-build branch July 1, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants