Improve compact benchmark #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft since sqlite tests are not compiling if dqlite lib is missing. |
marco6
force-pushed
the
improve-compact-benchmark
branch
from
b5a1832
to
e432c32
Compare
Merged
bschimke95
reviewed
Jun 26, 2024
There was a problem hiding this comment.
Great work @marco6
Did a first pass - code looks good to me. However, the PR does more than what it currently says, e.g. updating the version command, adding dqlite tag fields etc.
I would ask you to either put the rationale for that in the PR description or split this into a separate one.
|
Agreed. I will link here all the smaller PRs I create and mark this as draft for now. |
|
Depends on #110 |
|
Depends on #111 |
marco6
force-pushed
the
improve-compact-benchmark
branch
from
61e9b51
to
6b2d0b7
Compare
Signed-off-by: Marco Manino <marco.manino@canonical.com>
Signed-off-by: Marco Manino <marco.manino@canonical.com>
Signed-off-by: Marco Manino <marco.manino@canonical.com>
Signed-off-by: Marco Manino <marco.manino@canonical.com>
Signed-off-by: Marco Manino <marco.manino@canonical.com>
marco6
force-pushed
the
improve-compact-benchmark
branch
from
6b2d0b7
to
a22ab77
Compare
|
All pending PR were merged. Marking as ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at making the
compactbenchmark a little bit better.The main problem with the current approach is that it measures insertions and deletions together with the compaction itself - and those two operations are taking the most of the time. This means that the result of the benchmark is not very representative of what compaction does.
Also, the test takes from 5 to 7 *minutes to run a single iteration which is basically most of the execution time for the benchmark themselves. Running only one iteration makes the measure unreliable and difficult to compare.
This PR attempts to solve those issues by:
b.Nso that Go can take measures accurately;It also moves the benchmark (and the test) to the
driverspackage as compaction is a backend operation (in fact, during tested logic, theclientwas used just to set up the test and as such has been removed).Last, tests under kind folder were not running. Now they are, but I had to fix the
TestMigrateas it wasn't working. If required that can be moved to another PR before this one.