Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve retry logic #110

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Improve retry logic #110

merged 2 commits into from
Jul 1, 2024

Conversation

marco6
Copy link
Collaborator

@marco6 marco6 commented Jun 27, 2024

During high contention SQLite will sometime return SQLITE_BUSY. In those cases, the driver should retry the query for some arbitrary number of times, before giving up, to make the query more reliable.

This PR adds both the logic for sqlite driver and the generic retry logic for GetCompactRevision which was missing it.

@marco6 marco6 requested a review from a team as a code owner June 27, 2024 06:46
@marco6 marco6 mentioned this pull request Jun 27, 2024
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marco6
Copy link
Collaborator Author

marco6 commented Jul 1, 2024

As discussed on MM, we can merge even if Trivy scan is failing.

@marco6 marco6 merged commit 39e829d into canonical:master Jul 1, 2024
8 of 9 checks passed
@marco6 marco6 deleted the improve-retry-logic branch July 1, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants