Skip to content

Commit

Permalink
fix(ci): Run tests in testing namespace and add logging (#253)
Browse files Browse the repository at this point in the history
* fix(ci): Run tests in `testing` namespace and add logging

* pass {posargs}

Closes #252
  • Loading branch information
orfeas-k authored Dec 9, 2024
1 parent 5803946 commit 5b6c85b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/integrate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,16 @@ jobs:
charmcraft-channel: 3.x/stable

- run: |
sg snap_microk8s -c "tox -e ${{ matrix.charm }}-integration"
sg snap_microk8s -c "tox -e ${{ matrix.charm }}-integration -- -- --model testing"
# Collect debug logs if failed
- name: Dump Juju/k8s logs on failure
uses: canonical/kubeflow-ci/actions/dump-charm-debug-artifacts@main
if: always()
if: failure()

- name: Dump logs
if: failure()
uses: canonical/charming-actions/dump-logs@2.6.3

test-bundle:
name: Test the bundle
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ setenv =
lint: TYPE = lint
integration: TYPE = integration
commands =
tox -c charms/katib-{env:CHARM} -e {env:TYPE}
tox -c charms/katib-{env:CHARM} -e {env:TYPE} {posargs}

[testenv:update-requirements]
allowlist_externals =
Expand Down Expand Up @@ -66,4 +66,4 @@ description = Check code against coding style standards
[testenv:bundle-integration]
commands = pytest -v --tb native --show-capture=no --log-cli-level=INFO -s {posargs} {toxinidir}/tests/integration
deps =
-r requirements-integration.txt
-r requirements-integration.txt

0 comments on commit 5b6c85b

Please sign in to comment.