Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Run tests in testing namespace and add logging #253

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix(ci): Run tests in testing namespace and add logging #253

merged 2 commits into from
Dec 9, 2024

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Dec 4, 2024

Closes #252

@orfeas-k orfeas-k requested a review from a team as a code owner December 4, 2024 09:47
NohaIhab
NohaIhab approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logs are now visible in the artifacts, thx @orfeas-k !

@orfeas-k orfeas-k merged commit 5b6c85b into main Dec 9, 2024
25 checks passed
@orfeas-k orfeas-k deleted the orfeas-k-fix-logs branch December 9, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NohaIhab NohaIhab NohaIhab approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: logs are not fetched because tests run in a different model tham the action
2 participants
@orfeas-k @NohaIhab