Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging relation to katib-controller charm #187

Closed
rgildein opened this issue Jun 3, 2024 · 1 comment · Fixed by #195
Closed

Add logging relation to katib-controller charm #187

rgildein opened this issue Jun 3, 2024 · 1 comment · Fixed by #195
Labels
enhancement New feature or request

Comments

@rgildein
Copy link
Contributor

rgildein commented Jun 3, 2024

Context

Add logging relation using loki_push_api interface and LogForwarder to katib-controller charm. Alternatively the LogProxyConsumer, could be used if the service is using log file instead of STDOUT, however this needs to be discussed because LogProxyConsumer is marked as deprecated.

This task is part of the COS integration initiative for all Kubeflow charms.

What needs to get done

  1. Add logging relation using loki_push_api interface
  2. Use LogForwarder or LogProxyConsumer
  3. Use chisme abstraction for testing

Definition of Done

  1. Charm could be related with grafana-agent-k8s via logging relation
  2. This relation was tested by integration tests
  3. This relation was tested manually with COS deployed
@rgildein rgildein added the enhancement New feature or request label Jun 3, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5776.

This message was autogenerated

rgildein added a commit that referenced this issue Jun 17, 2024
Added logging relation and cos integration tests from chisme.

fixes: #187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant