-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging relation katib-controller #195
Conversation
Added logging relation and cos integration tests from chisme. fixes: #187
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is looking really good, just a tiny nit. I will run some manual tests and report my findings. Thanks @rgildein !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have run both the integration tests and the manual tests. Thanks @rgildein !
EDIT: I approved the PR, but there is a conflict with a file. Please rebase your branch and I can re-approve if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rgildein !
Added logging relation and cos integration tests from chisme.
fixes: #187
How I tested it:
from terminal
I visit
http://<ip>/cos-grafana/explore
to explore the logs and see:Duplicated logs are also visible with kubectl, so if that's an issue we should report it, but fix by this PR.