Skip to content

Commit

Permalink
chore: move core24 gnome-extension to stable (#4799)
Browse files Browse the repository at this point in the history
The gnome extension for core24 is considered stable now that
the gpu-2404 SDK has been integrated.
  • Loading branch information
jssotomdz authored Jun 17, 2024
1 parent 69b5948 commit 14dbf54
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 16 deletions.
5 changes: 0 additions & 5 deletions snapcraft/extensions/gnome.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,6 @@ def get_supported_confinement() -> Tuple[str, ...]:
@staticmethod
@overrides
def is_experimental(base: Optional[str]) -> bool:
# core24 is experimental until streamlined graphics support is finalized
# see https://forum.snapcraft.io/t/39718
if base == "core24":
return True

return False

@overrides
Expand Down
2 changes: 0 additions & 2 deletions tests/spread/core24/linters-pack/task.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ environment:
SNAP/library_ignored_mixed: library-ignored-mixed
SNAP/library_missing: library-missing
SNAP/library_unused: library-unused
# gnome-extension core24 is experimental
SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS: "1"

restore: |
cd "${SNAP}"
Expand Down
12 changes: 3 additions & 9 deletions tests/unit/extensions/test_gnome.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,9 @@ def test_get_supported_confinement():
assert gnome.GNOME.get_supported_confinement() == ("strict", "devmode")


@pytest.mark.parametrize(
("base", "is_experimental"),
[
("core22", False),
("core24", True),
],
)
def test_is_experimental(base, is_experimental):
assert gnome.GNOME.is_experimental(base=base) is is_experimental
@pytest.mark.parametrize("base", ["core22", "core24"])
def test_is_experimental(base):
assert gnome.GNOME.is_experimental(base=base) is False


def test_get_app_snippet(gnome_extension):
Expand Down

0 comments on commit 14dbf54

Please sign in to comment.