chore: move gnome-extension to stable #4799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm very interested in this as Chromium Dev now requires a new enough version of Pipewire not available in core22 and the alternative of building Pipewire from source is not so nice. |
mr-cal
requested changes
Jun 13, 2024
There was a problem hiding this comment.
@jssotomdz, can you drop the changes to snapcraft/services/provider.py and tests/unit/services/test_provider.py?
That code is not specific to the gnome extension, it's generic code for any experimental extension.
done! |
mr-cal
approved these changes
Jun 13, 2024
mattculler
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)This PR will have to wait for the support for streamlined graphics as stated by #4736
We want to have it ready for that so we can start migrating desktop snaps to core24 when that is done