Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: update ruby bundle v1 spread test #4013

Merged
merged 1 commit into from
Jan 12, 2023
+4 −2
Merged

tests: update ruby bundle v1 spread test #4013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/spread/plugins/v1/ruby/snaps/ruby-bundle-install/snap/snapcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
name: ruby-bundle-install
version: "1.0"
summary: Test bundle install
description: |
Snap to test 'bundle install' command
description: Snap to test 'bundle install' command

grade: devel
base: core18
Expand All @@ -17,3 +16,6 @@ parts:
plugin: ruby
source: .
use-bundler: true
ruby-version: "2.6.10" # bundler requires ruby >= 2.6.0
Copy link
Collaborator Author

@mr-cal mr-cal Jan 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cautious to make changes to the v1 plugin itself, due to the fact that it's been stable for a long time and that I don't know much about Ruby.

I am considering updating the documentation to mention the BUNDLE_GEMFILE environment variable. Or it could become a parameter in the snapcraft.yaml (i.e. ruby-gemfile-location: <path-to-gemfile>).

Aside: Ruby 2.6 is EOL and the latest supported release is 3.2. Not sure if/when it's appropriate to update the default Ruby version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I think this is a good minimal change to get this spread test fixed. However, if it works on Ruby 2.7 that'd probably be reasonable since it should be fully backwards compatible.

In theory Ruby 3 is backwards compatible too, but we should probably make a separate project for bringing our ruby deps up to the latest.

build-environment:
- BUNDLE_GEMFILE: "$SNAPCRAFT_PART_SRC/Gemfile"