-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: update ruby bundle v1 spread test #4013
Conversation
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@@ -17,3 +16,6 @@ parts: | |||
plugin: ruby | |||
source: . | |||
use-bundler: true | |||
ruby-version: "2.6.10" # bundler requires ruby >= 2.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm cautious to make changes to the v1 plugin itself, due to the fact that it's been stable for a long time and that I don't know much about Ruby.
I am considering updating the documentation to mention the BUNDLE_GEMFILE
environment variable. Or it could become a parameter in the snapcraft.yaml (i.e. ruby-gemfile-location: <path-to-gemfile>
).
Aside: Ruby 2.6
is EOL and the latest supported release is 3.2
. Not sure if/when it's appropriate to update the default Ruby version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I think this is a good minimal change to get this spread test fixed. However, if it works on Ruby 2.7 that'd probably be reasonable since it should be fully backwards compatible.
In theory Ruby 3 is backwards compatible too, but we should probably make a separate project for bringing our ruby deps up to the latest.
Codecov Report
@@ Coverage Diff @@
## main #4013 +/- ##
=======================================
Coverage 91.61% 91.61%
=======================================
Files 77 77
Lines 5153 5153
=======================================
Hits 4721 4721
Misses 432 432 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
make lint
?pytest tests/unit
?Ruby's
bundler v3.4.0
dropped support for Ruby <v2.6
, which broke one of our spread tests for the core18 / v1 Ruby plugin.