Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel plugin: add debhelper build dependency #4185

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

kubiko
Copy link
Contributor

@kubiko kubiko commented May 31, 2023

debhelper package contains some of the dependencies required by debian/rules clean
This is called as part of the kernel build if kernel-kconfigflavour is used.

@sergiusens sergiusens changed the base branch from main to hotfix/7.4 May 31, 2023 17:22
@kubiko kubiko force-pushed the kernel-missing-debhelper branch from 215995f to 11e0068 Compare June 6, 2023 12:41
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #4185 (f0e7335) into hotfix/7.4 (c0e7fd9) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           hotfix/7.4    #4185   +/-   ##
===========================================
  Coverage       94.85%   94.85%           
===========================================
  Files             648      648           
  Lines           54353    54353           
===========================================
  Hits            51554    51554           
  Misses           2799     2799           
Impacted Files Coverage Δ
snapcraft/parts/plugins/kernel.py 100.00% <ø> (ø)
snapcraft_legacy/plugins/v2/kernel.py 95.74% <ø> (ø)
tests/legacy/unit/plugins/v2/test_kernel.py 98.51% <ø> (ø)
tests/unit/parts/plugins/test_kernel.py 98.57% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…es clean" call

Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
@kubiko kubiko force-pushed the kernel-missing-debhelper branch from 11e0068 to 4189919 Compare June 6, 2023 12:43
@kubiko
Copy link
Contributor Author

kubiko commented Jun 6, 2023

rebasing, to mix merge conflict

@sergiusens sergiusens merged commit 389462c into canonical:hotfix/7.4 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants