Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel plugin: add debhelper build dependency #4185

Merged
merged 4 commits into from
Jun 6, 2023
Merged

kernel plugin: add debhelper build dependency #4185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4189919
kernel plugin: add debhelper build dependency required by "debian/rul…
kubiko May 31, 2023
3b7d673
Merge branch 'hotfix/7.4' into kernel-missing-debhelper
mr-cal Jun 6, 2023
b9f5a83
Merge branch 'hotfix/7.4' into kernel-missing-debhelper
mr-cal Jun 6, 2023
f0e7335
Merge branch 'hotfix/7.4' into kernel-missing-debhelper
mr-cal Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions snapcraft/parts/plugins/kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ def get_build_packages(self) -> Set[str]:
build_packages = {
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand Down
1 change: 1 addition & 0 deletions snapcraft_legacy/plugins/v2/kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,7 @@ def get_build_packages(self) -> Set[str]:
build_packages = {
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand Down
7 changes: 7 additions & 0 deletions tests/legacy/unit/plugins/v2/test_kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ def test_get_base_build_packages(self):
{
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand All @@ -285,6 +286,7 @@ def test_get_base_build_packages_lz4(self):
{
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand All @@ -304,6 +306,7 @@ def test_get_base_build_packages_xz(self):
{
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand All @@ -323,6 +326,7 @@ def test_get_base_build_packages_zfs(self):
{
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand All @@ -347,6 +351,7 @@ def test_get_base_build_packages_zfs_cross(self):
{
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand Down Expand Up @@ -1002,6 +1007,7 @@ def test_use_llvm(self):
{
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand Down Expand Up @@ -1034,6 +1040,7 @@ def test_use_llvm_specific_version(self):
{
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand Down
8 changes: 8 additions & 0 deletions tests/unit/parts/plugins/test_kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ def test_get_base_build_packages(self, setup_method_fixture, new_dir):
assert plugin.get_build_packages() == {
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand All @@ -92,6 +93,7 @@ def test_get_base_build_packages_lz4(self, setup_method_fixture, new_dir):
assert plugin.get_build_packages() == {
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand All @@ -113,6 +115,7 @@ def test_get_base_build_packages_xz(self, setup_method_fixture, new_dir):
assert plugin.get_build_packages() == {
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand All @@ -134,6 +137,7 @@ def test_get_base_build_packages_zfs(self, setup_method_fixture, new_dir):
assert plugin.get_build_packages() == {
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand Down Expand Up @@ -161,6 +165,7 @@ def test_get_base_build_packages_zfs_cross(self, setup_method_fixture, new_dir):
assert plugin.get_build_packages() == {
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand Down Expand Up @@ -188,6 +193,7 @@ def test_get_base_build_packages_efi(self, setup_method_fixture, new_dir):
assert plugin.get_build_packages() == {
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand Down Expand Up @@ -1094,6 +1100,7 @@ def test_use_llvm(self, setup_method_fixture, new_dir):
assert plugin.get_build_packages() == {
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand Down Expand Up @@ -1128,6 +1135,7 @@ def test_use_llvm_specific_version(self, setup_method_fixture, new_dir):
assert plugin.get_build_packages() == {
"bc",
"binutils",
"debhelper",
"fakeroot",
"gcc",
"cmake",
Expand Down