Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): Upgrade UI dependencies #79

Merged
merged 13 commits into from
Jul 17, 2024

Conversation

deadlycoconuts
Copy link
Contributor

@deadlycoconuts deadlycoconuts commented Jul 8, 2024

Context

Similar to what had been done in MLP caraml-dev/mlp#100, Merlin caraml-dev/merlin#591 and in Turing caraml-dev/turing#384, this PR updates certain UI dependencies in XP, most notably:

  • node.js from v16 to v20 (an engines.node field is added in the package.json file to pin the engine to >=20.13.1)
  • react from v17 to v18
  • elastic UI from v66 to v88.2.0* 🚨 this was intentionally left at this version because updating it to v88.3.0 breaks all the EuiAccordion-related components; this is likely due a massive rework of the component in this PR [EuiAccordion] Split up rendering into sub-components & other cleanups elastic/eui#7161 but I've no idea why this change didn't affect the accordions in Merlin

Other minor changes have also been made to the GitHub CICD files.

Main Changes

  • Upgrading of UI dependencies
  • Upgrading of multiple GitHub actions; see the subsection below for more information

GitHub Actions Updates

  • actions/upload-artifact - from v2 to v4 since the former has already been deprecated since the 30th of June this year
  • actions/download-artifact - from v2 to v4 since the former has already been deprecated since the 30th of June this year (the versions of this action and upload-artifact need to be compatible to work)
  • actions/checkout - from v3 to v4 since it's similarly done in the MLP repo
  • actions/setup-go - from v4 to v5 since it's similarly done in the MLP repo (also provides caching)
  • actions/setup-python - from v2 to v5 to keep it updated to the latest version (also provides caching)
  • docker/login-action - from v1 to v3 just to keep it updated to the latest version

@deadlycoconuts deadlycoconuts added the enhancement New feature or request label Jul 8, 2024
@deadlycoconuts deadlycoconuts self-assigned this Jul 8, 2024
@deadlycoconuts deadlycoconuts force-pushed the upgrade_ui_dependencies branch from f8b2d26 to 4598083 Compare July 10, 2024 08:32
@deadlycoconuts deadlycoconuts force-pushed the upgrade_ui_dependencies branch from 9d7cafe to 4467270 Compare July 10, 2024 09:51
@deadlycoconuts deadlycoconuts marked this pull request as ready for review July 10, 2024 10:24
@deadlycoconuts deadlycoconuts requested a review from leonlnj July 10, 2024 10:24
Copy link
Contributor

@leonlnj leonlnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, same concern, roadblock should be noted somewhere so we dont waste time going over them again

@deadlycoconuts
Copy link
Contributor Author

Yeap, I just added them as comments in the package.json file here https://github.com/caraml-dev/xp/pull/79/files#diff-193b27d62e4fbda3d563009fed5ec6761a05f73558d94b39fab63ae948c679eaR6. Thanks for the review; merging this now!

@deadlycoconuts deadlycoconuts merged commit 7a0bf3a into caraml-dev:main Jul 17, 2024
11 checks passed
@deadlycoconuts deadlycoconuts deleted the upgrade_ui_dependencies branch July 17, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants