Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs extended] Disabled item borders wrong color on md and sm #6986

Closed
RichKummer opened this issue Aug 25, 2021 · 3 comments
Closed

[Tabs extended] Disabled item borders wrong color on md and sm #6986

RichKummer opened this issue Aug 25, 2021 · 3 comments
Assignees
Labels
bug Something isn't working Carbon Core dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package
Milestone

Comments

@RichKummer
Copy link

Detailed description

When an item in the accordion version of Tabs extended is disabled, and the accordion item appears in md and sm breakpoints, the disabled item's top and bottom borders appear as the wrong color. The color of the disabled borders should be the same as the actionable item borders, only the text color and icon color are changed visually (see design specs).

Seen in Chrome in Canary Web Components v1.8.1 (http://ibmdotcom-web-components-canary.mybluemix.net/?path=/story/components-tabs-extended--default_ and the new version of the React wrapper for Tabs extended.

Tabs extended in Canary Web Components v1.8.1
Tabs-extended-current

Tabs extended md breakpoint in design specs
Tabs-extended-md

Tabs extended sm breakpoint in design specs
Tabs-extended-sm

It looks like the issue may be these lines of code effecting the disabled item (through Inspect)
Tabs-extended-inspect

Steps to reproduce the issue

  1. Configure a disabled item in Tabs extended
  2. View in breakpoint md or sm
  3. Compare top and bottom border color for disabled item with enabled item
@emyarod
Copy link
Member

emyarod commented Aug 25, 2021

it seems like these disabled accordion item styles come directly from core Carbon, should this be an upstream change or are we looking to scope it to the dotcom repo?

@RobertaJHahn
Copy link

Andrew to investigate as part of Fireline. Will open in Core Carbon and close if it has to be fixed in Carbon.

@emyarod
Copy link
Member

emyarod commented Sep 7, 2021

this should be resolved when the carbon-components version is upgraded to v10.43.0 to include the upstream fix carbon-design-system/carbon#9543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Carbon Core dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package
Projects
None yet
Development

No branches or pull requests

8 participants