Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled accordion item rule dividers not receiving expected color change #9542

Closed
emyarod opened this issue Aug 26, 2021 · 2 comments · Fixed by #9543
Closed

Disabled accordion item rule dividers not receiving expected color change #9542

emyarod opened this issue Aug 26, 2021 · 2 comments · Fixed by #9543

Comments

@emyarod
Copy link
Member

emyarod commented Aug 26, 2021

Are there any planned updates to the disabled accordion divider rules? It was changed to $disabled-02 (#8081), updated to $border-disabled (#8425), but then reverted back to $disabled-02 (#9064).

This is what a disabled accordion looks like currently using carbon-components styles ($disabled-02)

image

vs Carbon next using the styles package ($border-disabled)

image

related downstream issue: carbon-design-system/carbon-for-ibm-dotcom#6986

@tw15egan
Copy link
Collaborator

tw15egan commented Aug 26, 2021

I believe it still needs to use the old tokens (due to an issue we had to revert), but perhaps the borders should be disabled-01?

Screen Shot 2021-08-26 at 3 59 18 PM

@emyarod
Copy link
Member Author

emyarod commented Aug 26, 2021

got it, updated #9543 to use disabled-01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants