Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(accordion): updated disabled item tokens #9543

Merged
merged 2 commits into from
Aug 30, 2021
Merged

fix(accordion): updated disabled item tokens #9543

merged 2 commits into from
Aug 30, 2021

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Aug 26, 2021 •
edited
Loading

Closes #9542

This PR updates the carbon-components disabled accordion styles to match the styles package

Changed

  • disabled accordion item color tokens

Testing / Reviewing

with the updated tokens the disabled accordion item now appears like this

image

compared to

image

@emyarod emyarod requested a review from a team as a code owner August 26, 2021 13:51
@netlify
Copy link

netlify bot commented Aug 26, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 4865e0d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/612cfd28b7d4930007d0153d

😎 Browse the preview: https://deploy-preview-9543--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 26, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 4865e0d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/612cfd287c152f0008acc3ff

😎 Browse the preview: https://deploy-preview-9543--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 26, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 4865e0d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/612cfd28d61e760008dcde42

😎 Browse the preview: https://deploy-preview-9543--carbon-components-react.netlify.app

@emyarod emyarod force-pushed the 9542-fix/disabled-accordion-item-rule-divider-tokens branch from a3acd0c to 3eb3e6f Compare August 26, 2021 14:17
@emyarod emyarod mentioned this pull request Aug 26, 2021
Closed
tw15egan
tw15egan approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing 🙏🏻 LGTM

@kodiakhq kodiakhq bot merged commit 305eb46 into carbon-design-system:main Aug 30, 2021
@emyarod emyarod deleted the 9542-fix/disabled-accordion-item-rule-divider-tokens branch August 30, 2021 19:50
This was referenced Sep 1, 2021
Merged
Merged
@emyarod emyarod mentioned this pull request Sep 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@tw15egan tw15egan tw15egan approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabled accordion item rule dividers not receiving expected color change
3 participants
@emyarod @joshblack @tw15egan