Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(masthead-platform): add check if next to logo and contains link #7468

Merged
merged 6 commits into from
Oct 21, 2021
Merged

test(masthead-platform): add check if next to logo and contains link #7468

merged 6 commits into from
Oct 21, 2021

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

#7357

Description

Add tests for masthead with platform. Checks if the platform positioning is next to the IBM logo and checks if there is a href

Changelog

New

  • test checking for link
  • test checking for positioning next to logo

@ariellalgilmore ariellalgilmore added the test: e2e used for automated e2e testing label Oct 20, 2021
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner October 20, 2021 21:56
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 20, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/7468/index.html

Built with commit: d14fe6ea66b91aa8790cbb688c0879b7cc063bbd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 20, 2021 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7468/index.html

Built with commit: d14fe6ea66b91aa8790cbb688c0879b7cc063bbd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 20, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7468/index.html

Built with commit: d14fe6ea66b91aa8790cbb688c0879b7cc063bbd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 20, 2021 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7468/index.html

Built with commit: d14fe6ea66b91aa8790cbb688c0879b7cc063bbd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 20, 2021 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7468/index.html

Built with commit: d14fe6ea66b91aa8790cbb688c0879b7cc063bbd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 20, 2021 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7468/index.html

Built with commit: d14fe6ea66b91aa8790cbb688c0879b7cc063bbd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 20, 2021 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7468/index.html

Built with commit: d14fe6ea66b91aa8790cbb688c0879b7cc063bbd

annawen1
annawen1 reviewed Oct 21, 2021
View reviewed changes
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just nitpicking on the test descriptions 😅

emyarod
emyarod approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just one more edit to the test case names!

packages/react/tests/e2e-storybook/cypress/integration/Masthead/Masthead.e2e.js Outdated Show resolved Hide resolved
packages/web-components/tests/e2e-storybook/cypress/integration/masthead/masthead.e2e.js Outdated Show resolved Hide resolved
ariellalgilmore and others added 2 commits October 21, 2021 08:13
@ariellalgilmore @emyarod
Update packages/react/tests/e2e-storybook/cypress/integration/Masthea…
dd5c8b8 
…d/Masthead.e2e.js

Co-authored-by: andrew <emyarod@users.noreply.github.com>
@ariellalgilmore @emyarod
Update packages/web-components/tests/e2e-storybook/cypress/integratio…
d14fe6e 
…n/masthead/masthead.e2e.js

Co-authored-by: andrew <emyarod@users.noreply.github.com>
@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Oct 21, 2021
@annawen1 annawen1 mentioned this pull request Oct 21, 2021
Closed
@kodiakhq kodiakhq bot merged commit c891998 into carbon-design-system:master Oct 21, 2021
@emyarod emyarod mentioned this pull request Oct 22, 2021
Closed
@ariellalgilmore ariellalgilmore deleted the test/masthead-platform branch October 25, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 left review comments

@emyarod emyarod emyarod approved these changes

@oliviaflory oliviaflory Awaiting requested review from oliviaflory oliviaflory was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge test: e2e used for automated e2e testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ariellalgilmore @ibmdotcom-bot @emyarod @annawen1 @jeffchew