Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image size on accessibility color page #1904

Merged
merged 3 commits into from
Oct 19, 2020
Merged

fix: image size on accessibility color page #1904

merged 3 commits into from
Oct 19, 2020

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Oct 19, 2020

Closes #1679

Changelog

Updated image size on the A11y > Color page /guidelines/accessibility/color/#use-of-color-and-color-blindness to span 8 columns across, and removed the extra white-space to the side of the image.

https://carbondesignsystem-git-fix-image-size.carbon-design-system.vercel.app/guidelines/accessibility/color#use-of-color-and-color-blindness

@alisonjoseph alisonjoseph requested a review from a team October 19, 2020 16:40
@alisonjoseph alisonjoseph requested a review from a team as a code owner October 19, 2020 16:40
@vercel
Copy link

vercel bot commented Oct 19, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/punuuidqp
✅ Preview: https://carbondesignsystem-git-fix-image-size.carbon-design-system.vercel.app

@alisonjoseph alisonjoseph requested review from a team and laurenmrice and removed request for a team and dakahn October 19, 2020 17:54
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@kodiakhq kodiakhq bot merged commit 4f0ac1b into carbon-design-system:master Oct 19, 2020
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility color blindness chart is a strange size in desktop and mobile.
3 participants