Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs: Remove max-width from Tab #11766

Closed
Tracked by #8487
abbeyhrt opened this issue Jul 7, 2022 · 5 comments · Fixed by #13247
Closed
Tracked by #8487

Tabs: Remove max-width from Tab #11766

abbeyhrt opened this issue Jul 7, 2022 · 5 comments · Fixed by #13247
Assignees
Labels
component: tabs proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡
Milestone

Comments

@abbeyhrt
Copy link
Contributor

abbeyhrt commented Jul 7, 2022

This issue is for simply removing the max-width property from Tab to allow them to flow to 100% the width of their content.

@tay1orjones tay1orjones changed the title Remove max-width from Tab Tabs: Remove max-width from Tab Dec 7, 2022
@tay1orjones
Copy link
Member

tay1orjones commented Dec 13, 2022

Is this resolved by the automatic prop addition? No

@tay1orjones
Copy link
Member

@aagonzales should this be an option, or should it be that all tabs no longer have a max width and will never truncate?

@abbeyhrt
Copy link
Contributor Author

If it helps @tay1orjones, here's the comment that I made this issue from #11765 (review)

@aagonzales
Copy link
Member

hmm I want to say let's kill max width completely, mostly for the sake of translation etc. Hopefully, designers and content designers are creating tab names with intentions.

My one hesitation around removing it altogether would be in regards to user or system generate tab names that could become excessively long. I'm not sure how likely this use-case would be, its probably not common. If we remove it, would a team be able to easily place a max-width if this happened to be a recurring problem in their product?

@tay1orjones
Copy link
Member

Thanks @abbeyhrt!

@aagonzales Yes, if we remove it altogether it could be a significant visual change in apps where they're relying heavily on truncation. It would be very easy for them to add it back in within their own app's stylesheet though.

@sstrubberg sstrubberg added this to the 2023 Q1 milestone Dec 14, 2022
@sstrubberg sstrubberg added type: enhancement 💡 proposal: accepted This request has gone through triaging and we are accepting PR's against it. labels Dec 20, 2022
@francinelucca francinelucca self-assigned this Feb 23, 2023
@kodiakhq kodiakhq bot closed this as completed in #13247 Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabs proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants